Thanks for working on this! I refactored the code to be faster and smaller. It should hopefully have the same behavior 🙂

A few thoughts:

1

I don't love searching every directory above us for anything ending in .gemspec. It might get unreasonable on pathological filesystems, and anything that can happen will happen 😄

I have absolutely no ruby-world knowledge, but according to my very brief research (https://piotrmurach.com/articles/writing-a-ruby-gem-specification/), the convention is to name the file package.gemspec. Do you think just searching for that would work?

2

Do we want to include .tool-versions in this search list? Is there any guarantee that the user is actually using the .tool-versions file to specify a ruby version, or could they be using it for something else and we're just showing useless information? This is the disadvantage of a general version manager I suppose.

I have absolutely no ruby-world knowledge, but according to my very brief research (https://piotrmurach.com/articles/writing-a-ruby-gem-specification/), the convention is to name the file package.gemspec. Do you think just searching for that would work?

It would not work. The convention is package.gemspec. That is, I maintain a package called diff-lcs. Its gemspec is diff-lcs.gemspec.

2

Do we want to include .tool-versions in this search list? Is there any guarantee that the user is actually using the .tool-versions file to specify a ruby version, or could they be using it for something else and we're just showing useless information? This is the disadvantage of a general version manager I suppose.

We would not, IMO. If it .tool-versions is found, it would be better to inspect it to see if it contains ^ruby\s+\d. Otherwise, ruby --version might error out.

Thanks for the feedback, @IlanCosman . To answer your questions:

We actually do need to search for *.gemspec because gems typically don't use the name package.gemspec. For example, look at this gem that is part of Rails: https://github.com/rails/rails/tree/main/actioncable

The reason I was looking for .tool-versions was because I wanted to know which Ruby version is active in any directory I am in. But I understand others might not want that, so it's totally reasonable to remove it.

Would it be overkill to also look for *.rb?

The reason I was looking for .tool-versions was because I wanted to know which Ruby version is active in any directory I am in. But I understand others might not want that, so it's totally reasonable to remove it.

I can understand this, but I think that this is a viable request for pretty much any of the widgets. Something like _tide_always ruby node and checking for contains -- ruby $_tide_always in the Ruby plug-in would be a better approach for this sort of thing. Something like $_tide_always would be a different feature/pull request, though.

With respect to *.rb…I do think it would be overkill to search all parents; I would maybe search the current directory for .rb files, but even that is probably overkill.

Cool let's merge this bad boy!